Exclude app usage events table from using window function #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Evan Farrar <[email protected]> Co-authored-by: Seth Boyles <[email protected]>
philippthun
approved these changes
Feb 15, 2023
|
I had a look at some database/query statistics/performance dashboards for our largest foundation and can confirm that queries on the I agree that we should revisit the use of the I'm also open to provide a means to disable the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the issue reported in #3117, we have noticed performance degradation when using the OVER window function with
app_usage_eventswhen the tables has a large-ish number of row (around 150,000). This PR disables use of the window function forapp_usage_events, just as we have disabled it forevents.@kathap @philippthun , since you both worked on the previous PR--are you concerned that this might be a trend with several of our tables? We don't have a lot of context on the performance benefits of the use of the OVER window function, and it feels like its use may be high risk. We were wondering if it might be worth disabling the OVER window for more models, or even all of them. Perhaps a configuration value in capi-release?
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests